Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] opens other's players trunk/glovebox randomly #559

Open
greenghoost opened this issue Jul 28, 2024 · 8 comments
Open

[BUG] opens other's players trunk/glovebox randomly #559

greenghoost opened this issue Jul 28, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@greenghoost
Copy link

greenghoost commented Jul 28, 2024

Summary

distance checking is not working for trunk or glovebox

Reproduction

open inventory

Expected behavior

It should not open other player's trunk or glovebox, even they are not near any trunk or inside any vehicle

Actual behavior

when 2/3 or many players are trying to open their inventory at the same time it opens other player's trunk or glovebox inventory randomly, distance checking is not working for trunk or glovebox. Then it gives a message this inventory is currently in use because of other player player got the INV open on his end.
any fix for this problem ?

Additional context

No response

Last Updated

today

Custom Resources

qb-inventory

Resource Rename

no

@greenghoost greenghoost added the bug Something isn't working label Jul 28, 2024
@Sanriku-Gaming
Copy link
Contributor

I would love to see a video clip of this. I just tested and had no issues opening my inventory without the trunk, unless I was close enough to a vehicle to open the trunk.

@greenghoost
Copy link
Author

I would love to see a video clip of this. I just tested and had no issues opening my inventory without the trunk, unless I was close enough to a vehicle to open the trunk.

this is video link- https://drive.google.com/file/d/1a99dNwlyrvVtDxvidytiSkORISnhe24P/view?usp=sharing
at the last added other player's INV screen shot

@Abracus
Copy link

Abracus commented Jul 28, 2024

Yeah the same thing happens to me. Messing with a lot of player Inventories and really hampering server economy.

@Faplas
Copy link
Contributor

Faplas commented Aug 26, 2024

I can confirm that this is still happening, i just did it with 2 players opening trunk at same time ,then they were opening eachothers trunks

@greenghoost
Copy link
Author

I can confirm that this is still happening, i just did it with 2 players opening trunk at same time ,then they were opening eachothers trunks

yes still not fixed yet

@Qwerty1Verified
Copy link
Contributor

Qwerty1Verified commented Sep 7, 2024

So in that video, both players were spamming tab? The second player stayed far away and was getting their own inventory, until randomly the second player got the trunk?

Perhaps a synchronous issue with client callbacks causing an overlap in the table and passing incorrect data back?

@Qwerty1Verified
Copy link
Contributor

Qwerty1Verified commented Sep 7, 2024

I forked and wrote a test fix on qb-core for the client callback logic, it works for me and may address the issue if my theory is correct.
Would a few of you be able to test it out? Just download my fork and drop in the modified files, I wouldn't bother manually changing it in case you place the changes in the wrong place.

Qwerty1Verified/qb-core@b9d91b3

@greenghoost
Copy link
Author

I forked and wrote a test fix on qb-core for the client callback logic, it works for me and may address the issue if my theory is correct. Would a few of you be able to test it out? Just download my fork and drop in the modified files, I wouldn't bother manually changing it in case you place the changes in the wrong place.

Qwerty1Verified/qb-core@b9d91b3

I think this fixed the issue. I tested and the problem is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants