Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default does not implement MarshalJSON #108

Open
asaf opened this issue Aug 17, 2021 · 0 comments · May be fixed by #109
Open

Default does not implement MarshalJSON #108

asaf opened this issue Aug 17, 2021 · 0 comments · May be fixed by #109

Comments

@asaf
Copy link

asaf commented Aug 17, 2021

Environment

What version of qri are you using (qri version)?

0.2.1

Issue

What happened?

The Default is not marshaled properly.
instead of the actual default value, it always yields {}

This is because the Default struct contains a private data which will never get marshalled without a custom MarshalJSON func.

What did you expect to happen?

The actual value to be jsonized.

Please link any related issues.

Do you have a suggested fix?

Yes, creating a PR now.
ranisharim-crossid added a commit to crossid/jsonschema that referenced this issue Aug 17, 2021
@ranisharim-crossid
add MarshalJSON for default
18cbf9a 
Closes qri-io#108
@ranisharim-crossid ranisharim-crossid linked a pull request Aug 17, 2021 that will close this issue
Open
asaf pushed a commit to crossid/jsonschema that referenced this issue Aug 17, 2021
@ranisharim-crossid @asaf
add MarshalJSON for default
2700f78 
Closes qri-io#108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add MarshalJSON for default crossid/jsonschema
1 participant
@asaf