Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PRGA in double factorization ProgRotGateArray #1319

Open
anurudhp opened this issue Aug 20, 2024 · 2 comments
Open

Use PRGA in double factorization ProgRotGateArray #1319

anurudhp opened this issue Aug 20, 2024 · 2 comments

Comments

@anurudhp
Copy link
Contributor

anurudhp commented Aug 20, 2024

class ProgRotGateArray(Bloq):
r"""Rotate to/from MO basis so-as-to apply number operators in DF basis.
An actual implementation of should derive from ProgrammableRotationGateArray.

@fdmalone
Copy link
Collaborator

I don't think this is actually equivalent. PRGA acts on a single target but this one needs to act on multiple targets. Ideally would be unified with the THC bloq (xref: #573).

@fdmalone
Copy link
Collaborator

Perhaps an intermediate step would be to not name this ProgRotGateArray and use something like #579 which may be a lot closer to having a real implementation given all the work on phase gradient rotations etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants