why would you get "The transaction is not active!" when @Transactional is on an @ApplicationScoped service

[kenyee]

Seeing this in production but not when running locally.

The endpoint doesn't have the @transactional marker:

@Path("/v1")
class UploadEndpoint {
    @Inject
    internal lateinit var metricsService: MetricsService

    @Path("/upload/{project}")
    @POST
    @Consumes(MediaType.APPLICATION_JSON)
    @Produces(MediaType.APPLICATION_JSON)
    fun uploadMetrics(
        @PathParam("project") project: String,
        @RestHeader(HEADER_APIKEY) apiKey: String,
        metrics: UploadMetricsData
    ): Uni<UploadResponse> {
        return Uni.createFrom().emitter<UploadResponse> { em ->
            val count = metricsService.addMetrics(project, metrics)
            em.complete(UploadResponse(count))
        }.runSubscriptionOn(executors.dbExecutor)
    }

but the service class does.
e.g.

@ApplicationScoped
class MetricsService {
    @Transactional
    @Throws(BadRequestException::class)
    fun addMetrics(projectName: String, metrics: UploadMetricsData) {
        ....
    }

and the error doesn't point to much more than the method and the error msg:

ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (vert.x-eventloop-thread-0) HTTP Request to /v1/upload/twitter-android failed, error id: c844e6ab-9bc3-4934-95c5-5f2b0161070e-3: javax.transaction.RollbackException: ARJUNA016102: The transaction is not active! Uid is 0:ffff0a393566:a8ed:626c3555:43a4
	at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.commitAndDisassociate(TransactionImple.java:1285)
	at com.arjuna.ats.internal.jta.transaction.arjunacore.BaseTransaction.commit(BaseTransaction.java:128)
	at io.quarkus.narayana.jta.runtime.CDIDelegatingTransactionManager.commit(CDIDelegatingTransactionManager.java:105)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorBase.endTransaction(TransactionalInterceptorBase.java:374)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorBase.invokeInOurTx(TransactionalInterceptorBase.java:170)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorBase.invokeInOurTx(TransactionalInterceptorBase.java:104)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorRequired.doIntercept(TransactionalInterceptorRequired.java:38)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorBase.intercept(TransactionalInterceptorBase.java:58)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorRequired.intercept(TransactionalInterceptorRequired.java:32)
	at io.quarkus.narayana.jta.runtime.interceptor.TransactionalInterceptorRequired_Bean.intercept(Unknown Source)
	at io.quarkus.arc.impl.InterceptorInvocation.invoke(InterceptorInvocation.java:41)
	at io.quarkus.arc.impl.AroundInvokeInvocationContext.perform(AroundInvokeInvocationContext.java:41)
	at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:32)
	at io.quarkus.arc.impl.InvocationContexts.performAroundInvoke(InvocationContexts.java:32)
	at org.twitter.teamcodehealth.service.MetricsService_Subclass.addMetrics(Unknown Source)
	at org.twitter.teamcodehealth.service.MetricsService_ClientProxy.addMetrics(Unknown Source)
	at org.twitter.teamcodehealth.endpoint.api.UploadEndpoint.uploadMetrics$lambda-0(UploadEndpoint.kt:54)

I dd a search and there are some mentions of @transactional only working with an @ApplicationScoped class' method and also not to do this on an async task (has to block until the response is sent or the transaction will be cancelled by sending the response).

[kenyee]

Also tried rewriting it so it uses an injected UserTransaction and transaction.begin()/commit() but I get:
RuntimeException: ARJUNA016108: Wrong transaction on thread
in unit tests that have the @transactional marker even though I do this in that method:

    fun addMetrics(projectName: String, metrics: UploadMetricsData) {
        try {
            if (transaction.status == Status.STATUS_NO_TRANSACTION) {
                transaction.begin()
            }

[kenyee]

Using transaction manager in the endpoint Uni call gives an interesting different call stack:

Caused by: org.hibernate.exception.GenericJDBCException: could not insert: [org.twitter.teamcodehealth.repository.MetricData]
	at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:42)
	at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:113)
	at org.hibernate.id.insert.AbstractReturningDelegate.performInsert(AbstractReturningDelegate.java:50)
	at org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:3279)
	at org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:3885)
	at org.hibernate.action.internal.EntityIdentityInsertAction.execute(EntityIdentityInsertAction.java:84)
	at org.hibernate.engine.spi.ActionQueue.execute(ActionQueue.java:645)
	at org.hibernate.engine.spi.ActionQueue.addResolvedEntityInsertAction(ActionQueue.java:282)
	at org.hibernate.engine.spi.ActionQueue.addInsertAction(ActionQueue.java:263)
	at org.hibernate.engine.spi.ActionQueue.addAction(ActionQueue.java:317)
	at org.hibernate.event.internal.AbstractSaveEventListener.addInsertAction(AbstractSaveEventListener.java:330)
	at org.hibernate.event.internal.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:287)
	at org.hibernate.event.internal.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:193)
	at org.hibernate.event.internal.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:123)
	at org.hibernate.event.internal.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:185)
	at org.hibernate.event.internal.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:128)
	at org.hibernate.event.internal.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:55)
	at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:107)
	at org.hibernate.internal.SessionImpl.firePersist(SessionImpl.java:756)

[kenyee]

Tried taking out the Uni code and using the endpoint as non-reactive but still get the same error:
ERROR [org.jbo.res.rea.com.cor.AbstractResteasyReactiveContext] (executor-thread-6) Request failed: javax.transaction.RollbackException: ARJUNA016102: The transaction is not active! Uid is 0:ffff0a393566:81ab:627144fb:1446

fun uploadMetrics(
        @PathParam("project") project: String,
        @RestHeader(HEADER_APIKEY) apiKey: String,
        metrics: UploadMetricsData
    ): UploadResponse {
  ...

[miladjafary]

I've the same error sometimes. but I don't how should I resolved, did you find any solution?

[yiyang-2280]

Faced the same error, in our case, it's a one minute timeout due to the default value for this property is 60s.
quarkus.transaction-manager.default-transaction-timeout

[kenyee]

sorry..forgot to respond. My mistake was trying to return Hibernate classes from an endpoint.
Fix was to convert the hibernate DTOs to regular DTOs because some of the magic that makes the hibernate lazy load values was being triggered by the JSON serializers.

[miladjafary]

Thank you. It's interesting. I don't have any hibernate DTOs and I solely use the normal Panache repository. But this error is happened regularly

[kenyee]

Panache is Hibernate underneath IIRC. Just make sure you don't try returning Panache entities in your JSON responses...

[miladjafary]

I did not return any Panache entity in my JSON response. Something else might poses the issue