Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate incoming relays from configuration #240

Open
ralexstokes opened this issue May 4, 2024 · 5 comments
Open

Deduplicate incoming relays from configuration #240

ralexstokes opened this issue May 4, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ralexstokes
Copy link
Owner

Both the builder and the boost components take a list of relays as part of the configuration.

You could currently provide duplicates and this would not really be useful in any way.

It would be nice to filter out duplicate relays when parsing from the configuration.

@ralexstokes ralexstokes added enhancement New feature or request good first issue Good for newcomers labels May 4, 2024
@ralexstokes
Copy link
Owner Author

This could also be an opportunity to build out a "relay set" abstraction, as some of the logic is getting duplicated across builder and boost.

@CristopherAguilar10
Copy link

hello @ralexstokes, can i work on this issue? i would like to help, thanks for the oportunity

@cyberbono3
Copy link

@CristopherAguilar10 is it still WIP?

@CristopherAguilar10
Copy link

@CristopherAguilar10 is it still WIP?

No, I was never assigned

@ralexstokes
Copy link
Owner Author

hey everyone, sorry for the delay

this issue has been handled in this PR, which I think is on the way to be merged in

#244

will try to pick out some more "good first issues"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants