Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make manual field in etcdsnaphot UX friendly #728

Open
alexander-demicev opened this issue Sep 5, 2024 · 1 comment
Open

Make manual field in etcdsnaphot UX friendly #728

alexander-demicev opened this issue Sep 5, 2024 · 1 comment
Labels
area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature

Comments

@alexander-demicev
Copy link
Member

Currently, we require users to always set Spec.Manual when they create a snapshot. The UX has to be simplified here. There are many to approach the problem, ideally controllers have to able to distinguish between manual snapshot and automatic ones without user setting any fields.
@alexander-demicev alexander-demicev added the area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature label Sep 5, 2024
@alexander-demicev alexander-demicev mentioned this issue Sep 5, 2024
Merged
4 tasks
@alexander-demicev
Copy link
Member Author

We can set an annotation on all automatically created snapshots and check for it in snapshot controller. Spec.Manual can be made Status.Manual and updated based on annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/etcdsnapshot-restore Categorizes issue or PR as related to Turtles ETCD Snapshot & Restore feature
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Status: CAPI Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexander-demicev