Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][adag] aDAG silently errors if task bind args do not match function signature #47709

Open
stephanie-wang opened this issue Sep 17, 2024 · 1 comment
Labels
accelerated-dag bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@stephanie-wang
Copy link
Contributor

What happened + What you expected to happen

We should throw an error if a task's bind args do not match its function signature.

Versions / Dependencies

3.0dev

Reproduction script

@ray.remote
class Actor:
  def foo(self):
    # doesn't take any args.
    return

a = Actor.remote()
with ray.dag.InputNode() as inp:
  # this line should error.
  dag = a.foo.bind(inp)

Issue Severity

None

@stephanie-wang stephanie-wang added bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks triage Needs triage (eg: priority, bug/not-bug, and owning component) accelerated-dag labels Sep 17, 2024
@kevin85421
Copy link
Member

kevin85421 commented Sep 20, 2024

I can't reproduce this issue. The exception is thrown when execute is called. Or should the exception be thrown when bind is called?

import ray
from ray.dag import InputNode


@ray.remote
class Actor:
  def foo(self):
    # doesn't take any args.
    return

a = Actor.remote()
with InputNode() as inp:
  # this line should error.
  dag = a.foo.bind(inp)
compiled_dag = dag.experimental_compile()

ref = dag.execute(5)
print(ray.get(ref))
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerated-dag bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

2 participants