Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the server status a normal status bar item #3416

Closed
jdneo opened this issue Dec 6, 2023 · 3 comments · Fixed by #3419
Closed

Make the server status a normal status bar item #3416

jdneo opened this issue Dec 6, 2023 · 3 comments · Fixed by #3419
Assignees
Labels

Comments

@jdneo
Copy link
Collaborator

jdneo commented Dec 6, 2023

Problem

Currently the server status is put inside the language status. The main problem of that is, user cannot see the server status unless user opens a java relate file. This experience is not ideal since the server status is hidden when the user is, for example, viewing the setting page.

Solution

Information like language level and project type can still be hosted by the language status bar, but put the server status as a general status bar item.

@rgrunber
Copy link
Member

rgrunber commented Dec 7, 2023

Right. So the language status bar is tied to a language, which would only be presented when an editor is open, but we have plenty of cases where the language server can do things and knowing its status would be useful. Only downside is the status bar area becomes a bit more crowded.

I guess as long as the user has the ability to hide the server status bar item, it should be ok to have it separate.

@IllusionMH
Copy link

But now it's either user hides status and there's no way to easy switch from light mode, or this status showed for totally unrelated files. Can it be setting where to show it?

@rgrunber
Copy link
Member

rgrunber commented Jan 18, 2024

@IllusionMH Even if the an unrelated file is open, if the language server is up, then it likely detected the opened folder is a Java project, or contains Java projects. It's difficult to know exactly when it should hide itself. We could use StatusBarItem.hide() if we had some cases where it absolutely makes sense to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants