Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses page #51

Open
gavv opened this issue Feb 5, 2023 · 5 comments
Open

Add licenses page #51

gavv opened this issue Feb 5, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@gavv
Copy link
Member

gavv commented Feb 5, 2023

Add a page that displays list of all dependencies and their licenses (including transitive ones).

Java dependencies can be gathered from gradle (I believe there should be gradle plugins for that). Information about roc license and dependencies can be found here:

@gavv gavv added enhancement New feature or request good first issue Good for newcomers help wanted Contributions are welcome labels Feb 5, 2023
@PranatPraveer
Copy link

From where the page should open in app ?
And do i need to create a new fragment?

@gavv
Copy link
Member Author

gavv commented Apr 8, 2023

Hi,

From where the page should open in app ?

From "About" page, I guess.

@githubashutoshsoni
Copy link
Contributor

githubashutoshsoni commented Oct 6, 2023

Can we do this as a webview? @gavv ? The page will open up and it will show https://roc-streaming.org/toolkit/docs/building/dependencies.html as a part of it?

@githubashutoshsoni
Copy link
Contributor

Can you please assign this to me? @gavv

@gavv
Copy link
Member Author

gavv commented Oct 6, 2023

I think webview with toolkit dependencies is not a good idea.

On one hand, we anyway should show many dependencies that are not listed there, and are specific to roc-java or roc-droid, but not roc-toolkit (I think you can somehow list them using gradle).

On the other hand, many dependencies of toolkit are not relevant to roc-droid, e.g. build time and developer dependencies. So we actually need to show only a few dependencies from toolkit docs.

I think we could use gradle for java dependencies and just add a few hard-coded dependencies for toolkit on top of that, and display them uniformly.

@gavv gavv removed good first issue Good for newcomers help wanted Contributions are welcome labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants