New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add record, stop, start_discovery and stop_discovery services for rosbag2_transport::Recorder #1634

Open

MichaelOrlov opened this issue May 5, 2024 · 0 comments

Labels

Contributor

MichaelOrlov commented May 5, 2024

Description

Expose rosbag2_transport::Recorder record, stop, start_discovery and stop_discovery APIs as a services

Related Issues

Relates Windows CI can't find metadata.yaml file when using ros2 bag record #926

Completion Criteria

Services for the rosbag2_transport::Recorder record, stop, start_discovery and stop_discovery exists

Implementation Notes / Suggestions

It is pretty trivial to add the same way as other services in the rosbag2_transport::Recorder.

Testing Notes / Suggestions

Will need to add more unit tests for the newly added services to the existent https://github.com/ros2/rosbag2/blob/rolling/rosbag2_transport/test/rosbag2_transport/test_record_services.cpp

The text was updated successfully, but these errors were encountered:

MichaelOrlov added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment