Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve querying (get a contract filtering by the GnosisSafe version that uses it) #1

Open
germartinez opened this issue May 7, 2021 · 0 comments
Open

Improve querying (get a contract filtering by the GnosisSafe version that uses it) #1

germartinez opened this issue May 7, 2021 · 0 comments
Assignees
@germartinez

Comments

@germartinez
Copy link
Member

germartinez commented May 7, 2021 •
edited
Loading

At first, it looks like every new version of the Safe contracts includes a new version for each contract (GnosisSafe, MultiSend, DefaultCallbackHandler, etc.) .

  • GnosisSafe v1.1.1 uses MultiSend v1.1.1
  • GnosisSafe v1.3.0 uses MultiSend v1.3.0

However, this is not always true. A specific version of the GnosisSafe contract might use a contract with a lower version number.

  • GnosisSafe v1.2.0 uses MultiSend v1.1.1 (MultiSend v1.2.0 does not exist)

It would be useful to get the specific contract used by a given GnosisSafe version by adding a new filter with the GnosisSafe version to the DeploymentFilter.
@germartinez germartinez self-assigned this May 7, 2021
@germartinez germartinez mentioned this issue May 7, 2021
Closed
@germartinez germartinez changed the title Improve querying (get all contracts given a specific GnosisSafe version) Improve querying (get all contracts used by a given GnosisSafe contract version) May 7, 2021
@germartinez germartinez changed the title Improve querying (get all contracts used by a given GnosisSafe contract version) Improve querying (get a contract filtering by the GnosisSafe version that uses it) May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germartinez germartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@germartinez