Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: replace safeAppId with origin #2067

Open
katspaugh opened this issue Jun 4, 2024 · 0 comments
Open

Messages: replace safeAppId with origin #2067

katspaugh opened this issue Jun 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@katspaugh
Copy link
Member

katspaugh commented Jun 4, 2024

What is needed?

The message proposal endpoint atm takes a safeAppId as a way to identify from where the message comes. This has a few issues:

  • It's not consistent with tx proposals which take an origin string (the URL of a dapp)
  • If you delete the matching Safe App, this ID cannot be recreated, so all the messages are orphaned
  • It doesn't convey any useful information for non-Safe App messages, i.e. for all WalletConnect-connected dapps
  • Transaction service knows nothing about Safe Apps, so it's not applicable to non-wallet ecosystem participants

Hence I suggest to replace safeAppId with an arbitrary URL (we can call it also origin), so that we can show something useful to the user in the history.

E.g. user connects to OpenSea and signs a message. We send a POST proposal with "origin": "https://opensea.io/". Message history returns https://opensea.io in the name field of the Message list item.

Endpoint

Screenshot 2024-06-04 at 12 01 33

Timeline

Q3 or later

@katspaugh katspaugh added the enhancement New feature or request label Jun 4, 2024
@Uxio0 Uxio0 assigned Uxio0 and unassigned Uxio0 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants