Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid closing code #118

Open
ghost opened this issue Aug 1, 2019 · 1 comment
Open

Invalid closing code #118

ghost opened this issue Aug 1, 2019 · 1 comment
Labels

Comments

@ghost
Copy link

ghost commented Aug 1, 2019

Looks like there is an error in Protocol. otherwise this errors is in implementations, js, java

A client who sends a 'close' message MUST set the reason field to a valid close code (as enumerated in Close Code Enumeration). 1001 SHALL be used for normal close cases.

From protocol MUST be sent 1001, but in both implementations is send 1000

@lgrahl lgrahl added the bug label Aug 6, 2019
@lgrahl
Copy link
Member

lgrahl commented Aug 6, 2019

Looks indeed like the clients are slightly wrong there, using 1000 instead of 1001 for pretty much everything. Not much of an issue but still a protocol violation.

When resolving this, an issue in the Java and Rust implementation should be filed (if needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant