Referenced document won't open in group tab. #7265
Assignees
Labels
Comments
|
Apologies, we are working on fixing this |
sjelfull
added a commit
that referenced
this issue
Aug 20, 2024
Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 20, 2024
* fix(core): ignore all input/textarea elements when copying fixes sdx-1591 Signed-off-by: Fred Carlsen <[email protected]> * fix(core): fix blur issue for references inside groups Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]> --------- Signed-off-by: Fred Carlsen <[email protected]>
|
Thanks for reporting, a fix for this will be included in the next release. |
cngonzalez
pushed a commit
that referenced
this issue
Aug 20, 2024
* fix(core): ignore all input/textarea elements when copying fixes sdx-1591 Signed-off-by: Fred Carlsen <[email protected]> * fix(core): fix blur issue for references inside groups Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]> --------- Signed-off-by: Fred Carlsen <[email protected]>
|
@sjelfull is the issue fixed? I still have it happening on my local project in sanity studio with the latest 3.55.0 version: Screen.Recording.2024-08-26.at.13.24.56.mov |
|
It's also still reproducible on the git repo. I've updated it to sanity 3.55.0. : Screen.Recording.2024-08-26.at.13.29.51.mov |
|
Bump, has this been fixed in 3.56? Can't see anything in the changelog. |
jordanl17
pushed a commit
that referenced
this issue
Aug 29, 2024
* fix(core): ignore all input/textarea elements when copying fixes sdx-1591 Signed-off-by: Fred Carlsen <[email protected]> * fix(core): fix blur issue for references inside groups Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]> --------- Signed-off-by: Fred Carlsen <[email protected]>
|
@jordanl17 this issue still hasn't been fixed in Studio V 3.57.0 |
|
Bump, can this issue be reopened? It's still not fixed! |
|
We are still looking into this. It is a bit tricky to find the root cause, since we are only able to reproduce it sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When trying to open a referenced document inside a group tab, the document doesn't open.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The referenced document should open in a new pane.
Currently this doesn't happen and is bugged.
It only opens when going to 'All Fields'.
Sanity Version
3.52.1
What operating system are you using?
Mac OS
Which versions of Node.js / npm are you running?
20.10.0
Video showing the bug:
Screen.Recording.2024-07-29.at.13.46.22.mov
The text was updated successfully, but these errors were encountered: