Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button in PortableText annotation causes popups to disappear in Safari #7351

Open
nring opened this issue Aug 9, 2024 · 1 comment

Comments

@nring
Copy link

nring commented Aug 9, 2024

Describe the bug

I have a customLink schema that allows a user to select a radio button to determine if a link is internal or external. Making the selection will show the appropriate field to select the link destination. For the purposes of this bug report, I have left that functionality out and all fields are currently displayed.

The bug occurs when selecting text in my PortableText editor and then clicking my link annotation component. The customLink component details pop up, but after selecting either radio button option the popup disappears. Sometimes I'm able to re-select the link text and fill in the rest of the details but other times I'm not able to get the popup to appear.

This only occurs in Safari 17.5 and Technology Preview 18.0. This does not occur in Chrome or Firefox.

To Reproduce

Steps to reproduce the behavior:

  1. Go to PortableText component and activate text area.
  2. Highlight text
  3. Select customLink annotation
  4. customLink details pops up
  5. Select a radio button
  6. customLink details immediately disappear

Expected behavior

I would expect the customLink details popup to stay open after selecting an Internal or External link.

Screenshots

sanity.mp4

Which versions of Sanity are you using?

@sanity/cli (global)          3.52.4 (latest: 3.53.0)
@sanity/cli                   3.53.0 (up to date)
@sanity/dashboard              3.1.6 (latest: 4.0.0)
@sanity/eslint-config-studio   4.0.0 (up to date)
@sanity/icons                  3.3.1 (up to date)
@sanity/vision                3.53.0 (up to date)
sanity                        3.53.0 (up to date)

What operating system are you using?
MacOS Sonoma.

Which versions of Node.js / npm are you running?

10.7.0
v20.15.1
1.22.19 (yarn)

Additional context

I recently upgraded to Sanity Studio 3 and this is the only bug I've found so far.

@nring
Copy link
Author

nring commented Sep 18, 2024

Confirming this is still an issue after Sanity 3.57.4, which looks to have addressed a number of PortableText decorator and annotation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant