Requires-Python from Wheel needs audit

[uranusjr]

No description provided.

[techalchemy]

I believe we need to clean it before we build the wheel

[uranusjr]

Forgot to mention but I experiemented a bit, and here’s the important part

passa/src/passa/dependencies.py

Lines 192 to 210 in eb7194d

	def _read_requires_python(metadata):
	"""Read wheel metadata to know the value of Requires-Python.
	This is surprisingly poorly supported in Distlib. This function tries
	several ways to get this information:
	* Metadata 2.0: metadata.dictionary.get("requires_python") is not None
	* Metadata 2.1: metadata._legacy.get("Requires-Python") is not None
	* Metadata 1.2: metadata._legacy.get("Requires-Python") != "UNKNOWN"
	"""
	# TODO: Support more metadata formats.
	value = metadata.dictionary.get("requires_python")
	if value is not None:
	return value
	if metadata._legacy:
	value = metadata._legacy.get("Requires-Python")
	if value is not None and value != "UNKNOWN":
	return value
	return ""

This is almost definitely not covering all cases, but I couldn’t find many good 1.x wheel examples, so we’ll have to fix it as we go.

Also I found that even if I’m reading the correct field, JSON API and the wheel can still return different values. This is just terrible.

[techalchemy]

oh yeah to summarize what we talked about whenever that was, and the reason why we have the custom cleaning stuff in pipenv, Requires-Python: 3 is completely valid for example

[uranusjr]

Indeed. This function (or the resolver in general) does not try to actually parse the string in any sense. The parsing part is done after the resolution, by the marker thing you implemented.