Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the ASCII color codes of k8s pod logs #502

Open
munishchouhan opened this issue May 15, 2024 · 0 comments
Open

Keep the ASCII color codes of k8s pod logs #502

munishchouhan opened this issue May 15, 2024 · 0 comments

Comments

@munishchouhan
Copy link
Member

Suggestion from @ewels
Was thinking about what you were saying about ASCII codes in the logs yesterday
. I wonder if we can keep them (maybe via a flag in the API?). I would love to be able to render the colours if possible as it makes the logs much easier to read.
The back-end used by Hub is written Python, and my favourite library Rich is able to convert ascii codes to html. So we might be able to do that on the round trip and preserve colour. On the Wave side we just have to not throw them out. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant