Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the touch pointer remove process #81

Open
GildasMorel opened this issue Sep 29, 2020 · 6 comments
Open

Fix the touch pointer remove process #81

GildasMorel opened this issue Sep 29, 2020 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Milestone

Comments

@GildasMorel
Copy link
Collaborator

GildasMorel commented Sep 29, 2020

The touch pointer is a plugin that add a pointer to the slide view.
From the presenter view, you can move the pointer by touching the slide view and it moves in the same way on stage view.

To activate this plugin, click on Presenter view "plugins" button menu and select "TouchPointerInput".
Then, to deactivate the plugin, click on the "Fermer" button at the top right.

When the plugin is activated, the pointer div is added on the fly to the view.
When the plugin is deactivated, it should be removed from the shadow DOM.

  • Checkout the develop branch
  • Open the file src\plugins\input\touch-pointer\index.js
  • Look for _removePointer function definition
  • The line pointer.remove(); doesn't work

You can see and confirm the problem by deactivating the plugin following the previous process and look for the pointer div in the dev tools.
If you activate / deactivate the plugin several times you'll see that you'll have several pointer div in the source code.

@GildasMorel GildasMorel added this to the 0.5 milestone Sep 29, 2020
@GildasMorel GildasMorel added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Sep 29, 2020
@devrasec
Copy link

Can I work on this issue?

@GildasMorel
Copy link
Collaborator Author

Hi, of course, I assigned the issue to you.
Let me know if you need more information.

@devrasec
Copy link

devrasec commented Oct 1, 2020

Great! thank you!

@GildasMorel
Copy link
Collaborator Author

Hi @devrasec, did you find a way to resolve this issue ?

@GildasMorel
Copy link
Collaborator Author

Sorry I didn't see you created a PR.
I'm reviewing it.
Thanks a lot.

GildasMorel added a commit that referenced this issue Oct 5, 2020
Fix touch-pointer remove process
Closes #81
@devrasec
Copy link

devrasec commented Oct 5, 2020

Great! not a problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants