Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cast): Incorrect detection of MediaCapabilities on Chromecast #6656

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(Cast): Incorrect detection of MediaCapabilities on Chromecast #6656

merged 1 commit into from
May 28, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 23, 2024

Fixes #5776

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: Cast Issues affecting Cast devices labels May 23, 2024
@avelad avelad added this to the v4.9 milestone May 23, 2024
@avelad
Copy link
Member Author

avelad commented May 23, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6656

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 00c5c1d into shaka-project:main May 28, 2024
34 of 35 checks passed
@shaka-bot shaka-bot mentioned this pull request May 28, 2024
Merged
@avelad avelad deleted the mcap-cast branch May 28, 2024 07:05
avelad added a commit that referenced this pull request May 28, 2024
@avelad
fix(Cast): Incorrect detection of MediaCapabilities on Chromecast (#6656
87eb506 
)

Fixes #5776
@shaka-bot shaka-bot mentioned this pull request May 28, 2024
Merged
@simonlary simonlary mentioned this pull request May 28, 2024
Open
joeyparrish pushed a commit that referenced this pull request May 31, 2024
@avelad @joeyparrish
fix(Cast): Incorrect detection of MediaCapabilities on Chromecast (#6656
7681d4f 
)

Fixes #5776
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@alekzz alekzz Awaiting requested review from alekzz

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

Assignees
No one assigned
Labels
platform: Cast Issues affecting Cast devices priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

Incorrect detection of MediaCapabilities on Chromecast, resulting in MEDIAKEYS_UNSUPPORTED error
3 participants
@avelad @shaka-bot @theodab