Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request and check a receipt in tests #2173

Closed
THenry14 opened this issue Jul 5, 2023 · 0 comments · Fixed by #2181
Closed

Request and check a receipt in tests #2173

THenry14 opened this issue Jul 5, 2023 · 0 comments · Fixed by #2181
Assignees
@war-in
Milestone
CLI in Rust

Comments

@THenry14
Copy link
Member

THenry14 commented Jul 5, 2023

Tests are using fixed number of accounts. Since they are run in parallel, it may be that hashes not always match the expected output. We should make raw requests to devnet and check the transaction status instead (we may also compare it with cli output if it makes sense)
@THenry14 THenry14 added this to the CLI in Rust milestone Jul 5, 2023
@war-in war-in mentioned this issue Jul 5, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 6, 2023
@war-in
[CLI] Check transaction receipt in tests (#2181)
6bcf2d0 
Closes #2173 

### Checklist
- [ ] Relevant issue is linked
- [ ] Docs updated/issue for docs created
- [ ] Added relevant tests
@THenry14 THenry14 mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@war-in war-in

Labels
None yet
Projects
None yet
Milestone
CLI in Rust
Development

Successfully merging a pull request may close this issue.

[CLI] Check transaction receipt in tests software-mansion/protostar
2 participants
@THenry14 @war-in