Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SiteSelector use isRouteUriDecorable instead of isRequestDecorable #1762

Open
Haniki opened this issue Jun 4, 2024 · 0 comments
Open

SiteSelector use isRouteUriDecorable instead of isRequestDecorable #1762

Haniki opened this issue Jun 4, 2024 · 0 comments
Labels
feature

Comments

@Haniki
Copy link

Haniki commented Jun 4, 2024

Feature Request

I see in BaseSiteSelector that we use the isRouteUriDecorable method in the onKernelRequest method.

https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Site/BaseSiteSelector.php#L54-L56

Shouldn't we use the isRequestDecorable method instead ? https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/CmsManager/DecoratorStrategy.php#L67

Without this, only the ignore_uri_patterns config is considered, and the ignore_route_patterns and the ignore_routes are ignored.
@Haniki Haniki added the feature label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Haniki