Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hx-Push-Url headers #3

Closed
dsyer opened this issue Sep 21, 2023 · 0 comments
Closed

Hx-Push-Url headers #3

dsyer opened this issue Sep 21, 2023 · 0 comments

Comments

@dsyer
Copy link
Member

dsyer commented Sep 21, 2023

The current version of HTMX uses "Hx-Push" so maybe that should be fixed (it still supports the older value used here). But I wonder why we use it at all? It's ugly to see the servlet request and response being used in controller methods, and makes them hard to test, and HTMX supports setting the push url in the HTML which seems like a good idea to me. Am I reading that right?

Fixed by #5 and #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant