Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page carousel is borked. #10

Open
dcporter opened this issue Nov 14, 2013 · 5 comments
Open

Home page carousel is borked. #10

dcporter opened this issue Nov 14, 2013 · 5 comments

Comments

@dcporter
Copy link
Member

New items enter from the left while old items depart to the left.

@topherfangio
Copy link
Contributor

As far as I can tell, this is working "as designed". It was apparently hand-written by whoever developed the page.

Should we consider dropping in a jQuery plugin or something instead?

@dcporter
Copy link
Member Author

yes yessss

@topherfangio
Copy link
Contributor

I attempted to do this, but realized that we're on a REALLY old version of jQuery and most of the sliders I found require a newer version. I tried to upgrade jQuery but that broke other things. I can investigate again later, but I'm honestly not sure if it's worth spending a ton of time on.

@dcporter
Copy link
Member Author

I don't recall the details, but isn't this a home-grown carousel? I would think it could be fixed in place without too much effort. But yeah annoying code is annoying; I defer to you.

As for upgrading jQuery, I think that comes down to whether we're planning to upgrade the website piecemeal, or put that off in favor of a full overhaul. I would love a full overhaul with a more modern look and layout, but I would love lots of things. Thoughts?

@topherfangio
Copy link
Contributor

The carousel is indeed home grown, and the code is pretty messy and horrible. It may be possible to fix this, but I spent about 30 minutes trying to figure out how the stupid CSS classes work (they attach webkit transitions by adding or removing classes), but I was never able to get old items to depart to the right.

I can try again, but as stated in today's meeting, time-consuming tasks to fix non-horribly-egregious should be avoided.

That said, if someone else wants to dive in and see if they can figure out the CSS classes or fix the JS to work better, please feel free; I won't be offended :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants