Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use github url when importing go-kallax #307

Open
elliott-davis opened this issue Mar 16, 2019 · 2 comments
Open

Don't use github url when importing go-kallax #307

elliott-davis opened this issue Mar 16, 2019 · 2 comments
Labels

Comments

@elliott-davis
Copy link

I lost a couple of hours this morning because I was importing github.com/src-d/go-kallax instead of gopkg.in/src-d/go-kallax.v1. Everything seemed to work (I vendored using dep) except I would always end up with a blank template for the kallax.go file. This isn't a super actionable issue other than maybe a stronger docs callout but I wanted to at least file an issue incase anyone else ran into the same problem.

@rp-codeyjenkins
Copy link

rp-codeyjenkins commented Aug 21, 2019

Thanks for this, saved me some time once I found your issue!

Also, this library is awesome!

Maybe on the readme in the example user struct at the top, an import statement could be added.

Like this:

package models

import "gopkg.in/src-d/go-kallax.v1"

type User struct {
        kallax.Model         `table:"users" pk:"id"`
        ID       kallax.ULID
        Username string
        Email    string
        Password string
}

@smola
Copy link
Contributor

smola commented Aug 27, 2019

@rp-codeyjenkins Your suggestion makes sense. We will accept a Pull Request for that. Thank you!

@smola smola added the docs label Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants