Fix convolution spec and outputs in README.md #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, sorry, this isn't ready yet. I just realized that the "+1" isn't an indexing nuance, it's actually a function of the size of "b" being so small. I'll run some more test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35
Updated the conv_spec function in the .py and .ipynb files. Updated README.md to match the changes.
This version of conv_spec was confirmed with the test case inputs against
numpy.convolution(a, b, mode='same')andcupy.convolution(a, b, mode='same'). All 3 calculations are in agreement for both test cases.The spec change doesn't make the problem particularly harder. The solution would require substituting
i - j + 1in place ofi + jand adding a check fori - j + 1 > size.Due to the added check, it may be worth updating the
conv_testtext from# FILL ME IN (roughly 17 lines)to# FILL ME IN (roughly 18 lines), however it's only a rough number of lines regardless.