New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training on test set? #202

Open

jilljenn opened this issue Nov 21, 2023 · 0 comments

jilljenn commented Nov 21, 2023

Hi, on the README you write:

estimated_rewards_by_reg_model = regression_model.fit_predict(
    context=bandit_feedback_test["context"],
    action=bandit_feedback_test["action"],
    reward=bandit_feedback_test["reward"],
)

But this is basically fitting on test rewards. Is this legal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment