Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release CmdStan 2.35 #1266

Closed
23 of 26 tasks
WardBrian opened this issue May 6, 2024 · 26 comments · Fixed by #1279
Closed
23 of 26 tasks

Release CmdStan 2.35 #1266

WardBrian opened this issue May 6, 2024 · 26 comments · Fixed by #1279
Assignees
@WardBrian @serban-nicusor-toptal

Comments

@WardBrian
Copy link
Member

WardBrian commented May 6, 2024 •
edited
Loading

Feature freeze (May 13th, 2024):

  • Ensure all expiring language deprecations have been removed or given new removal dates.
  • Create and merge version updating pull requests in Math/Stan/Cmdstan. These should be the last PRs accepted before the freeze.
  • Create Math/Stan RC releases.
  • Create Stanc3 RC binary.
  • Create a release candidate tarball for x86. Make sure RC tarballs include stanc3 binaries.
  • Check external links in docs (i.e. TBB docs link) - use https://github.com/tcort/markdown-link-check
  • Create a release candidate feature/bugfix list (major features/bugfixes that need testing, link to new docs in Github)
  • Run CmdStanR tests with the RC tarball.
  • Run CmdStanPy tests with the RC tarball.
  • Make a Discourse RC post.
  • Post a tweet with a link to the Discourse RC post.

Release (June 3rd, 2024):

  • Create the Math Release notes.
  • Create the Stan Release notes.
  • Create the Cmdstan Release notes.
  • Create the Stanc3 Release notes, include new deprecations and removals.
  • Rebuild and publish docs for the new version.
  • Check that docs for the previous release links correctly to the newest docs.
  • Create the Math release.
  • Create the Stan release.
  • Create the Stanc3 release.
  • Create x86 CmdStan tarballs (check version, check that the extracted folder is in the cmdstan-version format).
  • Create non-x86 CmdStan tarballs.
  • Run CmdStanR tests with the release tarball.
  • Make a Stan blog release announcement post (thank the sponsors and all contributors, mention new devs).
  • Link to the blog post in a Discourse thread.
  • Make a Twitter announcement.
@serban-nicusor-toptal
Copy link
Contributor

Good morning @WardBrian, I don't see anything pending in the discourse thread nor here. I will start shortly with the RC.

@serban-nicusor-toptal
Copy link
Contributor

serban-nicusor-toptal commented May 13, 2024 •
edited
Loading

RC is now out!
Version increment PRs merged, release notes to be added later on.

CmdStanR tests running at https://github.com/stan-dev/cmdstanr/actions/runs/9062601485

@WardBrian
Copy link
Member Author

Thank you! I will get working on release notes and a discourse post

@WardBrian
Copy link
Member Author

Hi @serban-nicusor-toptal - unfortunately I immediately found an issue - see #1270

Additionally, the stanc in the tarballs of rc1 reports the wrong version (it seems like stanc3 is missing a rc tag/build?)

@serban-nicusor-toptal
Copy link
Contributor

Ah, I thought for stanc3 we'll just use nightly.
I will tag it 2.35.0-rc1 in just a moment so it start building then I will redo the tarballs.

@WardBrian
Copy link
Member Author

I will merge #1270 as soon as its tests pass and then you can do another set of tars

Been a while since we had an rc2, I think.

@WardBrian
Copy link
Member Author

@serban-nicusor-toptal Merged, can re-tarball when you get a chance

@WardBrian
Copy link
Member Author

Preliminary (lightly edited) release notes here: https://gist.github.com/WardBrian/0791d82cfde4044a4b9c78aaf91f7c84

@serban-nicusor-toptal
Copy link
Contributor

Properly tagged stanc3 binaries currently building here https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/v2.35.0-rc1/1/pipeline
I'll fix RC1 tarballs when that will finish building.
I'm waiting before I do RC2 for cmdstan

@WardBrian
Copy link
Member Author

Ok, #1271 should be in rc2, I think.

@WardBrian
Copy link
Member Author

@serban-nicusor-toptal I think we can do rc2 now

@serban-nicusor-toptal
Copy link
Contributor

@WardBrian that's great! I can get to it in a few minutes. Only cmdstan right ?

@WardBrian
Copy link
Member Author

Yep! just the couple commits here and the re-built stanc3

@serban-nicusor-toptal
Copy link
Contributor

rc2 for cmdstan is up!
https://github.com/stan-dev/cmdstan/releases/tag/v2.35.0-rc2
colab is building, takes 10~mins

@WardBrian
Copy link
Member Author

CmdStanpy tests are normal. @andrjohns @jgabry can you comment on the cmdstanr tests? https://github.com/stan-dev/cmdstanr/actions/runs/9069238610/job/24918334234

@avehtari avehtari mentioned this issue May 16, 2024
Closed
@WardBrian
Copy link
Member Author

@serban-nicusor-toptal just a heads up, we will want a resolution to stan-dev/stan#3285 before any release. Depending on what we decide we may even want another round of RCs, so probably ~May 28 for the actual release at this point

@WardBrian
Copy link
Member Author

WardBrian commented May 21, 2024 •
edited
Loading

PRs we have merged/are aiming to merge between the first round of RCs and another round/eventual release:

@WardBrian
Copy link
Member Author

@serban-nicusor-toptal I think we are ready for another round of RCs tomorrow. Would you mind running them in the morning?

Unfortunately we need new RCs for everything:

  • math: v4.9.0-rc2
  • stan: v2.35.0-rc2
  • stanc3: v2.35.0-rc2
  • cmdstan: v2.35.0-rc3

@serban-nicusor-toptal
Copy link
Contributor

@WardBrian That's great! I'll do it tomorrow before US morning so it's ready when you log in.

@serban-nicusor-toptal
Copy link
Contributor

Good morning @WardBrian, everything is ready:

@WardBrian
Copy link
Member Author

Thanks @serban-nicusor-toptal!

I'm going to discuss when we'd like to do the official release with some other team members a bit later and get back to you.

@WardBrian
Copy link
Member Author

@serban-nicusor-toptal We decided to wait until the next non-US-holiday Monday, so we'd like to release on Monday, June 3rd

@WardBrian
Copy link
Member Author

Hi @serban-nicusor-toptal - it seems like cmdstan-2.35.0-rc3.tar.gz is missing stan-dev/math#3077 in the math submodule included in the tarball.

Would you mind producing a new one?

@serban-nicusor-toptal
Copy link
Contributor

Not at all! They're up now @WardBrian

@serban-nicusor-toptal
Copy link
Contributor

serban-nicusor-toptal commented Jun 3, 2024 •
edited
Loading

Releases are out now!

https://github.com/stan-dev/math/releases/tag/v4.9.0
https://github.com/stan-dev/stan/releases/tag/v2.35.0
https://github.com/stan-dev/cmdstan/releases/tag/v2.35.0
https://github.com/stan-dev/stanc3/releases/tag/v2.35.0

Docs building at: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FBuildDocs/detail/BuildDocs/52/pipeline

@WardBrian
Copy link
Member Author

@serban-nicusor-toptal great!

I think everything is looking good on the git side of things. We still need to make the develop -> master merges at some point

@WardBrian WardBrian linked a pull request Jun 5, 2024 that will close this issue
Update master to Release/v2.35.0 #1279
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WardBrian WardBrian

@serban-nicusor-toptal serban-nicusor-toptal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update master to Release/v2.35.0 stan-dev/cmdstan
2 participants
@WardBrian @serban-nicusor-toptal