Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentence does not parse #41

Open
tshepang opened this issue Jun 8, 2017 · 3 comments
Open

sentence does not parse #41

tshepang opened this issue Jun 8, 2017 · 3 comments

Comments

@tshepang
Copy link
Contributor

tshepang commented Jun 8, 2017

In 7-shared-and-networking.md, I struggle to understand this:

However, Cell only works with values that can be copied, that is, they implement Copy, like primitive types and structs containing them marked as 'derive(Copy)'.

It seems to say that Cell works with structs so long as its members are Copy, and itself is marked as Copy.

As an aside, perhaps splitting the sentence in 2 would help as well... it feels overlong.

@stevedonovan
Copy link
Owner

Yep, definitely too long. You did extract the meaning I was trying to put into the sentence, but the sentence is clumsy.

@stevedonovan
Copy link
Owner

How does this sound?

 However, `Cell` only works with values that can be copied 
 like primitive types and user types deriving the `Copy` trait.

@tshepang
Copy link
Contributor Author

tshepang commented Jun 9, 2017

I would:

However, Cell only works with Copy types (e.g. primitive types and user-defined types deriving the Copy trait).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants