Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High Security Vulnerability] due to outdated figma-api-exporter #15

Open
pedroresende opened this issue Aug 4, 2023 · 6 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pedroresende
Copy link

Describe the bug

You're using and outdated version of figma-api-exporter, which has a high security vulnerability because it's using axios

Steps to reproduce the behavior

  1. npm outdated
@pedroresende pedroresende added the bug Something isn't working label Aug 4, 2023
@pedroresende pedroresende changed the title [High Security Vulnerability] [High Security Vulnerability] due to outdated figma-api-exporter Aug 4, 2023
@silverwind
Copy link

There are a number of deprecations coming from this module:

npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility

npm WARN deprecated [email protected]: This SVGO version is no longer supported. Upgrade to v2.x.x.

npm WARN deprecated [email protected]: Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410

@silverwind
Copy link

silverwind commented Aug 4, 2023

Dependency chains for the three deprecations:

└─┬ @storybook/[email protected]
  └─┬ @storybook/[email protected]
    └─┬ @storybook/[email protected]
      └─┬ @svgr/[email protected]
        └── [email protected]

└─┬ @storybook/[email protected]
  └─┬ @storybook/[email protected]
    └─┬ @storybook/[email protected]
      ├── [email protected]
      └─┬ [email protected]
        ├── [email protected]
        └─┬ [email protected]
          └── [email protected]

└─┬ @storybook/[email protected]
  └─┬ @storybook/[email protected]
    └─┬ @storybook/[email protected]
      └─┬ @svgr/[email protected]
        └─┬ [email protected]
          └── [email protected]

@cdedreuille
Copy link
Contributor

cdedreuille commented Aug 6, 2023

Thanks a lot for looking into it @pedroresende @silverwind. The icon library doesn't have any dependencies. We only use these libraries locally to generate the icons from Figma. But I agree that we should take the time to fix it. The generator is not built with ESM and I'm not an expert of that. To update all libraries I believe we should fix this all together.

@cdedreuille cdedreuille added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Aug 6, 2023
@silverwind
Copy link

silverwind commented Aug 7, 2023

I see that d2f8113 moved all dependencies to devDependencies, so they will no longer install with 1.1.3 or above and this issue is resolved for users of the module. Developers may theoretically still be vulnerable, though.

@cdedreuille
Copy link
Contributor

Yes you're right @silverwind. I'll keep this issue open as this is still something I would love to resolve. I tried to convert our generator to ESM and updating all packages at the same time but I couldn't work everything out just yet.

@ekilah
Copy link

ekilah commented Oct 13, 2023

I opened slawomirkolodziej/figma-api-exporter#10 over there at the otherpackage to ask about the changes between 0.0.2 and 1.0.0 for what it's worth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants