Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial - Intermediate - Incorrect print message #126

Open
VaclavElias opened this issue Sep 13, 2023 · 4 comments
Open

Tutorial - Intermediate - Incorrect print message #126

VaclavElias opened this issue Sep 13, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p2 High priority, or is required as a base for other things

Comments

@VaclavElias
Copy link
Contributor

Mentioned by OmniOwl on Discord.

In your AsyncWebApi code example from the Intermediate C# template, you have a line that says "Press A to get Api data from..."
However your Input conditional is looking at the "G" key. Not A.

DebugText.Print($"Press A to get Api data from https://opencollective.com/stride3d", new Int2(drawX, drawY));

if (Input.IsKeyPressed(Stride.Input.Keys.G))
{
    await RetrieveStrideRepos();
    await Script.NextFrame();
}
@VaclavElias VaclavElias added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers p2 High priority, or is required as a base for other things labels Sep 13, 2023
@ChapCarr
Copy link

Hi, just checking you are looking to change the print out message and not the actual key that needs to be pressed?

@Vidhanvyrs
Copy link

I think @VaclavElias was asking to change the key binding to A rather D. And I think I can help with that Can you assign me with the issue so that I can start working on it immediately

@VaclavElias
Copy link
Contributor Author

VaclavElias commented Sep 14, 2023

Hello. Please double check what should be there in the accompanying video https://www.youtube.com/watch?v=xWozou1AJGM I think it should be 'A'. Also please use the staging branch, which is our New Docs, to be released soon, so your PR should go to staging and you need to clone staging as well.

Our staging web:
https://stride-doc-staging.azurewebsites.net/latest/en/

Thank you.

@VaclavElias
Copy link
Contributor Author

@Vidhanvyrs you can go ahead with the update as we have recently published new docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed p2 High priority, or is required as a base for other things
Projects
None yet
Development

No branches or pull requests

3 participants