Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] missing Postgres data types #2899

Open
basaran opened this issue Jul 14, 2021 · 4 comments
Open

[SQL] missing Postgres data types #2899

basaran opened this issue Jul 14, 2021 · 4 comments
Labels
C: Syntax T: enhancement Improvement of existing language features

Comments

@basaran
Copy link

basaran commented Jul 14, 2021

  • Sublime Version: 3.2
  • OS Version: Linux
CREATE TABLE IF NOT EXISTS public.dropzone_details
(
    id uuid NOT NULL DEFAULT uuid_generate_v4(),
    name text COLLATE pg_catalog."default",
    doc jsonb,
    poc json,
    size integer,
    CONSTRAINT id_name_uix UNIQUE (id, name)
)

Postgresql has some new data types introduced since version 9.5. It appears some of them are missing in SQL.sublime-syntax.

These data types should be added to SQL.sublime-syntax:

uuid
jsonb
json
xml
pg_snapshot
pg_lsn
txid_snapshot

Reference: https://www.postgresql.org/docs/13/datatype.html

@deathaxe deathaxe added the T: enhancement Improvement of existing language features label Aug 19, 2021
@deathaxe deathaxe changed the title missing data types for sql syntax [SQL] missing data types for sql syntax Aug 31, 2021
@jrappen
Copy link
Contributor

jrappen commented Sep 30, 2021

@basaran Maybe you could add this feedback to the current work on #3046 and check if that PR fixes all issues on your side?

@michaelblyons
Copy link
Collaborator

Postgres isn't (yet) a part of #3046. Someone could add an extra extended file and start adding one, though. A handful of data types would be an easy place to start.

@michaelblyons michaelblyons changed the title [SQL] missing data types for sql syntax [SQL] missing Postgres data types for sql syntax Sep 30, 2021
@michaelblyons michaelblyons changed the title [SQL] missing Postgres data types for sql syntax [SQL] missing Postgres data types Sep 30, 2021
@jrappen
Copy link
Contributor

jrappen commented Sep 30, 2021

From my understanding @keith-hall is still working on it, so now would be a good time to add this to the TODOs there I guess.

@jrappen
Copy link
Contributor

jrappen commented Oct 3, 2021

Mostly addressed by #3046 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Syntax T: enhancement Improvement of existing language features
Projects
None yet
Development

No branches or pull requests

4 participants