Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing plasma_mat_tag and sol_mat_tag with split chamber false results in an error #110

Open
Edgar-21 opened this issue Jun 1, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@Edgar-21
Copy link
Contributor

Edgar-21 commented Jun 1, 2024

I think we should probably just catch this and provide a useful error message?

@connoramoreno
Copy link
Collaborator

connoramoreno commented Jun 3, 2024

It should result in an error, since split_chamber determines whether plasma and SOL components are generated; the same goes for passing chamber_mat_tag when split_chamber is True. My thought was that the error message that results naturally would be enough, and that specially catching it would not be necessary, but perhaps the current error message isn't as self-explanatory as I think.

@Edgar-21
Copy link
Contributor Author

Edgar-21 commented Jun 3, 2024

It took me a while to figure it out, I'd imagine it would be even more cryptic without some level of familiarity with parastell

@gonuke
Copy link
Member

gonuke commented Aug 6, 2024

Do we need to improve documentation for this? error messages? or just close it?

@connoramoreno
Copy link
Collaborator

I think we should at least incorporate a specialized error message for this, perhaps in the corresponding setter/getter.

@connoramoreno connoramoreno added the documentation Improvements or additions to documentation label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants