Issue #12: Delete Items from Shopping List #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e JS confirm dialog and shows user a message accordingly.
|
Visit the preview URL for this PR (updated for commit 82b4ad2): https://tcl-74-smart-shopping-list--pr31-st-sd-12-jeqqigim.web.app (expires Wed, 25 Sep 2024 00:18:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79d73546692f99aad8468c28e36db434e2c190ac |
NickRoccodev11
approved these changes
Sep 18, 2024
dterceroparker
approved these changes
Sep 18, 2024
jtkabenni
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Hey team, looks good but it would be a good idea while testing to also test some of the other flows that happen on this page. So I marked an item as purchased, and also searched for items in the search bar and the success message remained, which was a little strange.
- I deleted an item, then marked another as purchased, but the deleted message remained. If you are creating a success message for one action, I would consider making sure the behavior is the same for the other.
2. If I search for something, the delete message remains.
Something you can consider is having the message time out after a few seconds, but just making sure the message reflects the most recent action is a good place to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to delete items from their shopping list.
Related Issue
Acceptance Criteria
ListItemcomponent renders a button that allows the user to delete an item from their list when clicked.deleteItemfunction inapi/firebase.jshas been filled out, and deletes the item from the Firestore database.Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
Listpage.Deletebutton for the item you would like to delete.OKto confirm.