Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry uses version like ^0.10.4 that are not Pipfile.lock complaint. #33

Open
todo bot opened this issue Mar 11, 2020 · 15 comments
Open

poetry uses version like ^0.10.4 that are not Pipfile.lock complaint. #33

todo bot opened this issue Mar 11, 2020 · 15 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. todo 🗒️ triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@todo
Copy link

todo bot commented Mar 11, 2020

micropipenv/micropipenv.py

Lines 458 to 463 in 96250e2

# TODO: poetry uses version like ^0.10.4 that are not Pipfile.lock complaint.
return info
def _poetry2pipfile_lock(
only_direct=False, no_default=False, no_dev=False


This issue was generated by todo based on a TODO comment in 96250e2 when #30 was merged. cc @fridex.
@todo todo bot added the todo 🗒️ label Mar 11, 2020
@todo todo bot assigned fridex Mar 11, 2020
@fridex
Copy link
Collaborator

fridex commented Jun 3, 2020

See Poetry docs for more info:

https://python-poetry.org/docs/versions/#version-constraints

To make this fully compliant, we will need to add support for:

  • caret requirements
  • tilde requirements
  • wildcard requirements

@fridex fridex removed their assignment Aug 18, 2020
@sesheta
Copy link
Member

sesheta commented Apr 17, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2021
@fridex
Copy link
Collaborator

fridex commented Apr 19, 2021

/remove-lifecycle stale

Low priority.

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2021
@goern
Copy link
Member

goern commented Jul 8, 2021

/kind feature
/priority backlog
/help
/good-first-issue
/label hacktoberfest

@sesheta
Copy link
Member

sesheta commented Jul 8, 2021

@goern:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature
/priority backlog
/help
/good-first-issue
/label hacktoberfest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. labels Jul 8, 2021
@sesheta
Copy link
Member

sesheta commented Aug 7, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 7, 2021
@wjhrdy
Copy link

wjhrdy commented Aug 11, 2021

Poetry natively supports a conversion to requirements.txt so we could attempt to mimic that.
I've found that most stable way to use micropipenv with poetry is to have poetry export a requirements.txt file.

poetry export -f requirements.txt --output requirements.txt --without-hashes

This seems to be the poetry function for this export:
https://github.com/python-poetry/poetry/blob/master/poetry/utils/exporter.py

If we are just interested in the conversion from ^1.2.3 to >=1.2.3 <2.0.0 we could use dephell as inspiration.

@sesheta
Copy link
Member

sesheta commented Sep 11, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Sep 11, 2021
@sesheta
Copy link
Member

sesheta commented Sep 11, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fridex
Copy link
Collaborator

fridex commented Sep 11, 2021

Thanks, @wjhrdy. This is valuable information. That sounds like the right way to extend the implementation.

/reopen
/remove-lifecycle rotten
/triage accepted

@sesheta
Copy link
Member

sesheta commented Sep 11, 2021

@fridex: Reopened this issue.

In response to this:

Thanks, @wjhrdy. This is valuable information. That sounds like the right way to extend the implementation.

/reopen
/remove-lifecycle rotten
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 11, 2021
@sesheta sesheta reopened this Sep 11, 2021
@sesheta sesheta removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2021
@goern
Copy link
Member

goern commented Oct 27, 2021

@frenzymadness is this a feature you would like to have/work on?

/lifecycle frozen

@sesheta sesheta added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 27, 2021
@frenzymadness
Copy link
Collaborator

@frenzymadness is this a feature you would like to have/work on?

Yes, I believe that the capability of parsing such versions will be useful in many use-cases but because it's complex to implement I cannot promise a deadline.

@goern
Copy link
Member

goern commented Mar 8, 2022

is this TODO still valid?

@goern
Copy link
Member

goern commented Apr 4, 2022

/sig user-experience

@sesheta sesheta added the sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Issues targeting the hacktoberfest participants. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. todo 🗒️ triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants