From 8693ec76d6dedadfbe4e170fb7eaabc8975d5962 Mon Sep 17 00:00:00 2001 From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> Date: Tue, 24 Nov 2020 18:49:13 +0100 Subject: [PATCH] fix: sync preferred select usage (#54) --- src/rules/select-style.ts | 2 +- tests/rules/store-select.test.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/rules/select-style.ts b/src/rules/select-style.ts index 7d204a51..02eeb52b 100644 --- a/src/rules/select-style.ts +++ b/src/rules/select-style.ts @@ -43,7 +43,7 @@ export default ESLintUtils.RuleCreator(docsUrl)({ 'Selectors should be used with the pipeable operator: this.store.pipe(select(selector))', }, }, - defaultOptions: [{ mode: OPERATOR }], + defaultOptions: [{ mode: METHOD }], create: (context, [{ mode }]) => { return { [pipeableSelect](node: TSESTree.CallExpression) { diff --git a/tests/rules/store-select.test.ts b/tests/rules/store-select.test.ts index ce001c82..f65b2dbb 100644 --- a/tests/rules/store-select.test.ts +++ b/tests/rules/store-select.test.ts @@ -11,7 +11,7 @@ import { ruleTester } from '../utils' ruleTester().run(ruleName, rule, { valid: [ - `this.store.pipe(select(selector));`, + `this.store.select(selector);`, { code: `this.store.pipe(select(selector));`, options: [{ mode: OPERATOR }], @@ -24,8 +24,8 @@ ruleTester().run(ruleName, rule, { invalid: [ fromFixture( stripIndent` - this.store.select(selector); - ~~~~~~~~~~~~~~~~~~~~~~~~~~~ [${operatorSelectMessageId}] + this.store.pipe(select(selector)); + ~~~~~~~~~~~~~~~~ [${methodSelectMessageId}] `, ), fromFixture( @@ -40,7 +40,7 @@ ruleTester().run(ruleName, rule, { fromFixture( stripIndent` this.store.select(selector); - ~~~~~~~~~~~~~~~~~~~~~~~~~~~ [${operatorSelectMessageId}] + ~~~~~~~~~~~~~~~~~~~~~~~~~~~ [${operatorSelectMessageId}] `, { options: [{ mode: OPERATOR }],