Support join hints in T-SQL

[10bas10]

Hi Guys,

Im working on supporting the parsing of join hints in T-SQL. For example:

SELECT a.x
FROM a
INNER HASH JOIN b
  ON b.id = a.id

The use of HASH here indicates the type of join that should be performed by SQL server. I was thinking of adding an argument named hint at the Join expression class and implement it as a list of join hints supplied. Then create a set that lists the tokens of such a hint coming from the dialect. After that adjust the generic _parse_join function to parse such hints.

Not sure whether there are multiple SQL languages that support hints between INNER and JOIN for example and therefore implement it within the generic parsing function.

What do you guys think?

[georgesittas]

Can you check if any of the other dialects supports this syntax? If it's just T-SQL, I'm not sure if it's worth adding complexity to the base parser / generator for this.

Besides that, I think the approach you're describing sounds legit.