Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up more test for Miri #6812

Open
tiif opened this issue Sep 1, 2024 · 5 comments
Open

Open up more test for Miri #6812

tiif opened this issue Sep 1, 2024 · 5 comments
Labels
A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate C-feature-request Category: A feature request.

Comments

@tiif
Copy link

tiif commented Sep 1, 2024

In the latest rustc nightly rustc 1.82.0-nightly (a7399ba69 2024-08-31), tokio API that requires epoll_wait can now run successfully in Miri. For reference, the tests that passed and were added to the Miri test suite can be found here: rust-lang/miri#3848. Is there any interest in opening up more tests to be run with Miri in tokio's CI?

@tiif tiif added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Sep 1, 2024
@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Sep 1, 2024
@Darksonn
Copy link
Contributor

Darksonn commented Sep 1, 2024

Absolutely. Currently we only run tests inside src/ with miri, but if we can start to run tests/ too, that'd be great, as the majority of our tests are located there.

@tiif
Copy link
Author

tiif commented Sep 1, 2024

Thanks! :)

I'd like to work on this so I'd know sooner if anything ICE'd miri, or what syscall should be supported next. But I have never contributed to tokio yet, so I might request for more guidance along the way.

@Darksonn
Copy link
Contributor

Darksonn commented Sep 1, 2024

You're definitely welcome to reach out to me on zulip or discord for that.

@tiif
Copy link
Author

tiif commented Sep 3, 2024

I found an ICE rust-lang/miri#3858 on miri side, so the test that ICE'd might be skipped until the fix landed on nightly, or this change should only be approved after all fixes are landed on nightly.

@Darksonn
Copy link
Contributor

Darksonn commented Sep 3, 2024

It's of course nice to enable as many tests as possible, but I suspect going from zero to all tests would be difficult, so I am okay with PRs that enable miri only on some of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate C-feature-request Category: A feature request.
Projects
None yet
Development

No branches or pull requests

2 participants