Conversion from TileXYZ into extendedSpatialID and SpatialID #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lIDs especially altitude conversion between AltitudeKeys and VerticalFIndex
in ConvertQuadkeysAndAltitudekeysToExtendedSpatialIDs
…for documentation
…ConvertTileXYZToExtendedSpatialIDs()` not to using Quadkey
If horizontal index conversion is needed, use HorizontalZoom alone; because this function does not need horizontal index conversion.
…tialIDs()` - tests are renamed(missing older commit) - added `ElementsMatch` for comparing slices without order
via `ConvertExtendedSpatialIDsToSpatialIDs` `HorizontalZoom` is refactored for using integer output
via `ConvertTileXYZToSpatialIDs` `ConvertExtendedSpatialIDsToSpatialIDs` is renamed to `ConvertExtendedSpatialIDToSpatialIDs`
about updating `ConvertQuadkeysAndAltitudekeysToExtendedSpatialIDs` to `ConvertTileXYZToExtendedSpatialIDs`
with sample program
mi-24v
added
documentation
HarutakaMatsumoto
requested changes
Aug 21, 2024
- replaced `fmt.Sprintf` as `strconv.FormatInt`
- removed golang.org/x/exp/maps
- replaced constants as `consts` package
- fixed wrong inline document
- `ConvertAltitudeKeyToZ`
- `TileXYZ`
- adjusted fields' integer size int64 - renamed `object.TileXYZ`s' test functions
- restructured conversion functions table - removed future plan column to prevent confusing - added overview of ConvertExtendedSpatialIDToSpatialIDs
- remove local `zOriginValue` (`consts.ZOriginValue` still remains) - renamed `ConvertAltitudeKeyToZ` to `ConvertAltitudeKeyToMinMaxZ`
- renamed `ConvertZToAltitudekey` to `ConvertZToMinMaxAltitudekey` - refactored tests using test table
- updated go version at build - upgraded external library
HarutakaMatsumoto
requested changes
Aug 23, 2024
- functions is renamed from `convertZToMinAltitudeKey` to `convertZToMinAltitudekey` - changed tests not to use test tables
HarutakaMatsumoto
approved these changes
Aug 23, 2024
|
@mi-24v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #27 and dealing #28 partially
ConvertTileXYZToSpatialIDs(combination of bellow functions)ConvertTileXYZToExtendedSpatialIDsConvertExtendedSpatialIDsToSpatialIDs