Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canFlipLeft / Right causes navigational arrows to blink #46

Open
piotrku opened this issue May 23, 2021 · 2 comments
Open

canFlipLeft / Right causes navigational arrows to blink #46

piotrku opened this issue May 23, 2021 · 2 comments

Comments

@piotrku
Copy link

piotrku commented May 23, 2021

When using:
:class="{ disabled: !flipbook.canFlipLeft }"
navigational arrows are in fact disabled when you reach the first/last page which is good. but they also get the disabled state during the page transitions, which looks strange and even annoying. I think that another computed boolean value like pageInTransition would solve the issue.

@ts1
Copy link
Owner

ts1 commented May 24, 2021

I will consider adding pageInTransition.
Since flipLeft only works if canFlipLeft is actually true, it's not a good thing to change the behavior of canFlipLeft.

@peaeater
Copy link

peaeater commented Jul 22, 2021

I avoid the navigational arrow blink by checking the flipbook's page number instead of canFlipLeft.
:class="{ disabled: flipbook.page === 1 }"
Similarly, the flip right button can check the flipbook's page against the page count.
:class="{ disabled: flipbook.page === flipbook.numPages }"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants