Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Remove JDBC reference from executor code #403

Open
Aryex opened this issue May 25, 2022 · 2 comments
Open

[REFACTOR] Remove JDBC reference from executor code #403

Aryex opened this issue May 25, 2022 · 2 comments
Labels

Comments

@Aryex
Copy link
Collaborator

Aryex commented May 25, 2022

Descriptions

Executors are not expected to use jdbc connections. However, we currently are passing JdbcLayerInterface references to them. This creates a few issues:

  1. [BUG] Connector write/read opens multiple connections #398 was caused by this and more bugs may come up in the future.
  2. It is also misleading since executors should not need to make any jdbc connections at all.

Thus, we should refactor the code to remove jdbc references from being passed down to executors, keeping it clean and avoiding future bugs.

@jeremyprime
Copy link
Collaborator

See also #324 for a related bug on this issue (and #314 before that, which was resolved).

@alexey-temnikov
Copy link
Collaborator

Downgraded to Normal priority since there is no functional or performance impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants