From 11eacfeadc9c116f372a363debef09c4dd77bef0 Mon Sep 17 00:00:00 2001 From: Yevhen Stepiuk Date: Wed, 5 Jul 2023 16:10:15 +0300 Subject: [PATCH] CXAN-368 Add name parameter to createNote API --- .../src/main/java/com/vimeo/networking2/VimeoApiClient.kt | 2 ++ .../networking2/internal/MutableVimeoApiClientDelegate.kt | 3 ++- .../com/vimeo/networking2/internal/VimeoApiClientImpl.kt | 6 +++++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/request/src/main/java/com/vimeo/networking2/VimeoApiClient.kt b/request/src/main/java/com/vimeo/networking2/VimeoApiClient.kt index eab21b45..fc0e8a5d 100644 --- a/request/src/main/java/com/vimeo/networking2/VimeoApiClient.kt +++ b/request/src/main/java/com/vimeo/networking2/VimeoApiClient.kt @@ -893,6 +893,7 @@ interface VimeoApiClient { * @param password The optional password will be needed to note on the [Video] if it is password protected. * @param coordinates The coordinates on the video surface where this note relates to. * @param timeCode The time code of the video this note relates to. + * @param name The optional guest name of the user who create note. * @param callback The callback which will be notified of the request completion. * * @return A [VimeoRequest] object to cancel API requests. @@ -903,6 +904,7 @@ interface VimeoApiClient { password: String?, coordinates: Coordinates, timeCode: Double, + name: String?, callback: VimeoCallback, ): VimeoRequest diff --git a/request/src/main/java/com/vimeo/networking2/internal/MutableVimeoApiClientDelegate.kt b/request/src/main/java/com/vimeo/networking2/internal/MutableVimeoApiClientDelegate.kt index eb6576b8..09e275f6 100644 --- a/request/src/main/java/com/vimeo/networking2/internal/MutableVimeoApiClientDelegate.kt +++ b/request/src/main/java/com/vimeo/networking2/internal/MutableVimeoApiClientDelegate.kt @@ -687,8 +687,9 @@ internal class MutableVimeoApiClientDelegate(var actual: VimeoApiClient? = null) password: String?, coordinates: Coordinates, timeCode: Double, + name: String?, callback: VimeoCallback - ): VimeoRequest = client.createNote(uri, text, password, coordinates, timeCode, callback) + ): VimeoRequest = client.createNote(uri, text, password, coordinates, timeCode, name, callback) override fun editNote( uri: String, diff --git a/request/src/main/java/com/vimeo/networking2/internal/VimeoApiClientImpl.kt b/request/src/main/java/com/vimeo/networking2/internal/VimeoApiClientImpl.kt index 6522d21d..f4189eb7 100644 --- a/request/src/main/java/com/vimeo/networking2/internal/VimeoApiClientImpl.kt +++ b/request/src/main/java/com/vimeo/networking2/internal/VimeoApiClientImpl.kt @@ -1307,14 +1307,18 @@ internal class VimeoApiClientImpl( password: String?, coordinates: Coordinates, timeCode: Double, + name: String?, callback: VimeoCallback ): VimeoRequest { val safeUri = uri.validate() ?: return localVimeoCallAdapter.enqueueInvalidUri(callback) - val body = mapOf( + val body = mutableMapOf( ApiConstants.Parameters.PARAMETER_COMMENT_TEXT_BODY to text, ApiConstants.Parameters.PARAMETER_COORDINATES to coordinates, ApiConstants.Parameters.PARAMETER_TIME_CODE to timeCode, ) + + name?.let { body[ApiConstants.Parameters.PARAMETER_USERS_NAME] = it } + return vimeoService.createNote(authHeader, safeUri, password, body).enqueue(callback) }