Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use opencsv in SaveFileConverters #55

Open
alee opened this issue Mar 28, 2019 · 0 comments
Open

use opencsv in SaveFileConverters #55

alee opened this issue Mar 28, 2019 · 0 comments
Labels
enhancement

Comments

@alee
Copy link
Member

alee commented Mar 28, 2019

should use opencsv to emit the save file txts to properly escape commas in chat messages, etc.
alee added a commit that referenced this issue Mar 28, 2019
@alee
make group UUIDs consistent across an experiment
3df1174 
- use generateNameUUID with a consistent name to set the group's uuid to
a deterministic uuid that stays the same across multiple rounds (so long
as the internal groupId did not change)
- add explicit double quotes around the chat messages themselves, should
look into using opencsv to generate proper CSVs that correctly escapes /
quotes things (#55)
alee added a commit that referenced this issue Mar 28, 2019
@alee
add opencsv dependency for #55
ada57f0
@alee alee mentioned this issue Apr 20, 2021
Closed
alee added a commit that referenced this issue Apr 21, 2021
@alee
fix: replace group UUID with date time group id
e57dedb 
- use StringEscapeUtils to properly escape the chat message for CSV
- TODO: push group id generation logic into sesef

stopgap for #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alee