Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up client source tree #764

Open
3 tasks
alee opened this issue Feb 1, 2022 · 0 comments
Open
3 tasks

clean up client source tree #764

alee opened this issue Feb 1, 2022 · 0 comments
Labels

Comments

@alee
Copy link
Member

alee commented Feb 1, 2022

  • client/src/components/game/phases/events/events
  • clarify purpose and contents of client/src/components/root and client/src/components/global (leaning towards moving contents of root into global)
  • unnecessary nesting for AccomplishmentCard (?)
@alee alee added the refactor label Feb 1, 2022
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue Mar 28, 2022
made breaking renames and refactors to implement better naming
conventions for components and types
remove duplicate nested events/events dir

refactored file structure:

events
|
|-- case (contains specific occurrences of a given event)
|
|-- type (categorizes events into 2 types: Basic and Interactive)
|
|-- Card.vue, Container.vue

naming convention for case/ components is: verb + noun/thing (e.g. VotePlayer)

other refactors:
EventClientView -> EventCase
currentEventView -> currentEventCase
clientViewHandler -> eventCaseClientHandler

refs virtualcommons#764
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue Mar 31, 2022
made breaking renames and refactors to implement better naming
conventions for components and types
remove duplicate nested events/events dir

refactored file structure:

events
|
|-- case (contains specific occurrences of a given event)
|
|-- type (categorizes events into 2 types: Basic and Interactive)
|
|-- Card.vue, Container.vue

naming convention for case/ components is: verb + noun/thing (e.g. VotePlayer)

other refactors:
EventClientView -> EventCase
currentEventView -> currentEventCase
clientViewHandler -> eventCaseClientHandler

refs virtualcommons#764
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue Apr 18, 2022
made breaking renames and refactors to implement better naming
conventions for components and types
remove duplicate nested events/events dir

refactored file structure:

events
|
|-- case (contains specific occurrences of a given event)
|
|-- type (categorizes events into 2 types: Basic and Interactive)
|
|-- Card.vue, Container.vue

naming convention for case/ components is: verb + noun/thing (e.g. VotePlayer)

other refactors:
EventClientView -> EventCase
currentEventView -> currentEventCase
clientViewHandler -> eventCaseClientHandler

refs virtualcommons#764
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue May 4, 2022
made breaking renames and refactors to implement better naming
conventions for components and types
remove duplicate nested events/events dir

refactored file structure:

events
|
|-- case (contains specific occurrences of a given event)
|
|-- type (categorizes events into 2 types: Basic and Interactive)
|
|-- Card.vue, Container.vue

naming convention for case/ components is: verb + noun/thing (e.g. VotePlayer)

other refactors:
EventClientView -> EventCase
currentEventView -> currentEventCase
clientViewHandler -> eventCaseClientHandler

refs virtualcommons#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant