Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hydration): avoid observing non-Element node #11954

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(hydration): avoid observing non-Element node #11954

wants to merge 11 commits into from

Conversation

linzhe141
Copy link
Contributor

close #11952

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+26 B) 38 kB (+9 B) 34.1 kB (-9 B)
vue.global.prod.js 159 kB (+26 B) 57.9 kB 51.4 kB (-15 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.4 kB 21.3 kB 19.4 kB
createSSRApp 59.4 kB 23 kB 21 kB
defineCustomElement 60.2 kB 22.9 kB 20.9 kB
overall 69.1 kB 26.4 kB 24 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 17, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11954

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11954

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11954

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11954

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11954

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11954

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11954

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11954

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11954

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11954

vue

pnpm add https://pkg.pr.new/vue@11954

commit: 7519226

@linzhe141 linzhe141 changed the title fix(runtime-core): regular comment nodes should not use hydrateOnVisible fix(runtime-core): add element type check before observing in hydrateOnVisible Sep 18, 2024
@edison1105 edison1105 changed the title fix(runtime-core): add element type check before observing in hydrateOnVisible fix(hydration): avoid observing non-Element node Sep 19, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope:hydration labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope:hydration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hydrateOnVisible() throws an error if the component does not render an element
2 participants
@linzhe141 @edison1105