fix(v-on-handler-style): fixed the breaking change caused by the auto-fix on functions without parameters（#2538） #2539
+269
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
requested changes
Aug 30, 2024
ota-meshi
reviewed
Sep 3, 2024
| idCallExpr /* The statement is not a simple identifier call and cannot be fixed. */ && | ||
| idCallExpr.arguments.length === 0 | ||
| ) { | ||
| const paramCount = methodParamCountMap.get(idCallExpr.callee.name) |
There was a problem hiding this comment.
I think this rule also has the number of arguments defined in the method. If we check that, I think some code can be safely fixed automatically.
If it's unsafe or we can't identify the number of arguments for the method, I think it's good to make it a suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2538