Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hashfragments in share target action #89

Open
JeremyMahieu opened this issue May 19, 2020 · 2 comments
Open

Support for hashfragments in share target action #89

JeremyMahieu opened this issue May 19, 2020 · 2 comments

Comments

@JeremyMahieu
Copy link

The use of '#!' in the share target action is not supported. But for (older) SPAs this would be usefull. The #! is usually a part of the routing but could be used for other extra information aswell.

"share_target": {
  "action": "/index.html/#!/share",
  "method": "GET",
  "params": {
    "title": "title",
    "text": "text",
    "url": "url"
  }
}
@mgiuca
Copy link
Collaborator

mgiuca commented May 20, 2020

I think this is supported right now (weirdly, it looks like we override the query, but not the fragment), according to this algorithm.

Does the fragment get deleted in the actual implementation?

@JeremyMahieu
Copy link
Author

I've tried with "action": "/#!/share", on android/chrome and it does not seem to route my app to the correct location. Wheras if I type in manually https://mydomain.com/#!/share it does route me to the correct page.

Don't take my word for it though, I'm not sure. There's a lot of caching going which is not ideal for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants