You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Serial-ATA We had some other code for logging in the past, but it was removed because it wasn't being used. Linking in case it is of use. Here is a past commit with it
If we don't pass around the Logger everywhere, we will still end up having to pass relevant vars elsewhere. Make sure, especially for testing, the first data we see is the name of the log (e.g., "Alice", "Bob", "Integration Test", "Blueprint-Manager-Alice", "Gadget-Alice", etc). Otherwise, what we have works and makes it easy and clear to follow. It also allows us to print to a file if needed (we use to have this, but keeping Logger allows us to easily do this) to separate logs between all the nodes when debugging. This makes causality easy to follow in a side-by-side comparison.
Overview
Logger
is simply a wrapper aroundlog
with a given ID: https://github.com/webb-tools/gadget/blob/main/common/src/debug_logger.rsThis can be replaced with
tracing
, which would allow us to provide that additional context, while also being able to:format!()
The text was updated successfully, but these errors were encountered: