Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyAccount Disable via UI in Sub Org Not Working #21149

Closed
asha15 opened this issue Sep 24, 2024 · 2 comments
Closed

MyAccount Disable via UI in Sub Org Not Working #21149

asha15 opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels

Comments

@asha15
Copy link
Contributor

asha15 commented Sep 24, 2024

Describe the issue:
Even though MyAccount is disabled via the UI in a sub-organization, the functionality is not working as expected. The UI shows a successful disable message, but it doesn't update via the API, and there is no change in the toggle for B2B MyAccount settings.

How to reproduce:
Navigate to the sub-organization's.
Disable the B2B MyAccount option.
Observe the success message confirming the disable action.
Check the API response and verify that no update has occurred.
Check the B2B MyAccount settings toggle; it remains unchanged.

Expected behavior:
Disabling MyAccount via the UI should correctly update the API, and the toggle in the B2B MyAccount settings should reflect the change.

Environment information (Please complete the following information; remove any unnecessary fields) :

  • Product Version: wso2is-7.0.1-SNAPSHOT

Optional Fields

Related issues:

Suggested labels:

@asha15 asha15 self-assigned this Sep 24, 2024
@asha15
Copy link
Contributor Author

asha15 commented Sep 24, 2024

Analysis

When the root organization "myaccount" is enabled and the sub-organization "myaccount" is disabled, during the application GET request from the FragmentApplicationMgtListener [1], the ApplicationEnabled property is overridden as true from the root organization, leading to an incorrect result in the API response.

[1] https://github.com/wso2-extensions/identity-organization-management/blob/3da1ad8bd2d265f13144d58041c6a0f65caa7e34/components/org.wso2.carbon.identity.organization.management.application/src/main/java/org/wso2/carbon/identity/organization/management/application/listener/FragmentApplicationMgtListener.java#L368.

Solution

The Shared application's property should be inherited from the root organization. Hence the application enabled property should be inherited from the root organization and the UI element to enable/disable the myaccount should be removed.

@asha15
Copy link
Contributor Author

asha15 commented Sep 24, 2024

Fixed with: wso2/identity-apps#6917

@asha15 asha15 closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant