Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xr.align instead of xr.broadcast #242

Open
aaronspring opened this issue Jan 14, 2021 · 1 comment
Open

xr.align instead of xr.broadcast #242

aaronspring opened this issue Jan 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@aaronspring
Copy link
Collaborator

there are two issues on xarray about xr.corr, from which we can improve xr.pearson_r and in general:

pydata/xarray#4804: use a, b = xr.align(a, b, exclude=dim) as broadcast has join="outer" which fills it with NA which then get ignored; align uses join="inner". I remember I implemented that, but I am no broadcasting/align expert. I was just happy tests passed...
Here we are also not sure why xs.pearson_r is faster than xr.corr

pydata/xarray#4768: I raised whether to implement weighted in xr.corr

@aaronspring aaronspring added the enhancement New feature or request label Jan 14, 2021
@aaronspring
Copy link
Collaborator Author

also fix that probabilistic members are broadcasted (except member_dim)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant