Unset an instance variable?

[CharlieHawker]

We are using render_anywhere to render a series of pages, and as such there is a loop.

There are some instances where instance variables are set on iterations of the loop that won't be needed on the next iteration. Leaving them assigned causes rendering issues, but there is no unset_instance_variable method (or similar).

Re-initializing the object which uses the render_anywhere gem on each iteration of the loop would evidently solve this but would be an expensive operation.

Would adding a method like the following be a viable solution?

def unset_instance_variable(var) 
  rendering_controller.class_eval do
    undef :"#{var}"
    undef :"#{var}="
  end
end

[robb1e]

Happy to look at at pull request if you have time.

Robbie

On Fri, 29 Apr 2016, 17:22 Charlie Hawker, [email protected] wrote:

We are using render_anywhere to render a series of pages, and as such
there is a loop.

There are some instances where instance variables are set on iterations of
the loop that won't be needed on the next iteration. Leaving them assigned
causes rendering issues, but there is no unset_instance_variable method
(or similar).

Re-initializing the object which uses the render_anywhere gem on each
iteration of the loop would evidently solve this but would be an expensive
operation.

Would adding a method like the following be a viable solution?

def unset_instance_variable(var)
rendering_controller.class_eval do
undef :"#{var}"
undef :"#{var}="
endend

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#28

[CharlieHawker]

Great. Working on one now after discussing best solution on stack overflow.

[CharlieHawker]

@robb1e am I missing something about testing? Both rake and rspec (even when prefixed with bundle exec) don't seem to be able to render the views in spec/views and the tests produce the following error:

RenderAnywhere#render renders with ivar
     Failure/Error: rendering_controller.render_to_string(*args)
     ActionView::MissingTemplate:
       Missing template spec/views/user_ivar with {:locale=>[:en], :formats=>[:html, :text, :js, :css, :ics, :csv, :png, :jpeg, :gif, :bmp, :tiff, :mpeg, :xml, :rss, :atom, :yaml, :multipart_form, :url_encoded_form, :json, :pdf, :zip], :handlers=>[:erb, :builder]}. Searched in:

Given Search in: is blank, is that a misconfiguration / version issue?

[robb1e]

Hmm, I just pulled the latest and run the tests successfully. Not sure what to suggest, I haven't been involved in this code base for a while.

[CharlieHawker]

Yep, it's driving me crazy too! Any particular version of Ruby / Rspec? Thanks for taking a look.